-
Notifications
You must be signed in to change notification settings - Fork 297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ADR009: Non-Interactive Default Rules for Reduced Padding #1003
Conversation
docs/architecture/adr-008-square-size-independent-message-commitments.md
Outdated
Show resolved
Hide resolved
Deferring to @liamsi and @adlerjohn |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't have any blocking feedback, it's all optional to make the document read easier.
I plan on doing another review later this week to inspect the math closer but don't want to block the PR on my re-review.
docs/architecture/adr-008-square-size-independent-message-commitments.md
Outdated
Show resolved
Hide resolved
Thinks i need to adjust the calculation:
|
2b38fa1
to
5b2093c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No blocking feedback, still LGTM
docs/architecture/adr-009-non-interactive-default-rules-for-reduced-padding.md
Outdated
Show resolved
Hide resolved
docs/architecture/adr-009-non-interactive-default-rules-for-reduced-padding.md
Show resolved
Hide resolved
docs/architecture/adr-009-non-interactive-default-rules-for-reduced-padding.md
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Really great analysis 👍 Left a few suggestions and questions. I'd defer to others before merging, but if this ADR is going stale after a month or so, I am fine merging provided we keep it as Proposed
status.
I still need to think about the tradeoffs a bit more, but fwiw I'm leaning towards being in favor of this proposal.
If we are only thinking about bandwidth costs of super light clients, and we are only thinking about 134MB blocks (square size 512) for the foreseeable future. Then in the worst possible case we would only increase super light clients bandwidth by about 11 GB per year. (roughly 2,102,400 blocks per year (4 per minute), max block size each block, and worst size of rollup block each block)
However, if we went with this proposal have a more efficient padding, then we would either have a smaller average square size or be able to post more data. If we have a smaller average square size, then we reduce the bandwidth costs of minimized light clients because they gossip a smaller average DAH.
docs/architecture/adr-009-non-interactive-default-rules-for-reduced-padding.md
Outdated
Show resolved
Hide resolved
docs/architecture/adr-009-non-interactive-default-rules-for-reduced-padding.md
Show resolved
Hide resolved
docs/architecture/adr-009-non-interactive-default-rules-for-reduced-padding.md
Show resolved
Hide resolved
docs/architecture/adr-009-non-interactive-default-rules-for-reduced-padding.md
Show resolved
Hide resolved
Unfortunately this might be false considering the Jevons_paradox. It would be the same as making Blockspace bigger to decrease congestion, but more block space could in turn create more demand creating the same congestion. |
docs/architecture/adr-009-non-interactive-default-rules-for-reduced-padding.md
Show resolved
Hide resolved
docs/architecture/adr-009-non-interactive-default-rules-for-reduced-padding.md
Show resolved
Hide resolved
docs/architecture/adr-008-square-size-independent-message-commitments.md
Show resolved
Hide resolved
docs/architecture/adr-009-non-interactive-default-rules-for-reduced-padding.md
Outdated
Show resolved
Hide resolved
what are the todos left on this @nashqueue before we merge? |
Nothing to add ship it. |
This PR is regarding this Question.
rendered