feat!: remove blobstream param subspace when upgrading to v2

[rootulp]

Closes #3397
Opens #3411

[coderabbitai]

Walkthrough

Walkthrough

The changes primarily focus on the blobstream module in the context of app upgrades from version 1 to version 2. A new conditional block in app/app.go ensures the removal of blobstream parameters when upgrading to version 3. Meanwhile, upgrade_test.go sees modifications to better handle import management and to test the absence of blobstream in version 2, adding a specific function to simulate this upgrade scenario.

Changes

File Path	Changes Summary
app/app.go	Added conditional block in EndBlocker to handle blobstream module params removal on upgrade to v3.
app/test/upgrade_test.go	Updated imports, added new tests for blobstream removal in v2, and added function to simulate upgrade from v1 to v2.

Assessment against linked issues

Objective	Addressed	Explanation
Ensure blobstream does not function in v2 (#3397, #3305)	✅
Remove blobstream CLI commands and gRPC queries in v2 (#3305)	❌	Changes related to CLI commands and gRPC queries are not part of the PR changes.
Add migration that deletes state in the blobstream module (#3305)	❓	The PR includes removal of blobstream params, but it's unclear if this equates to deleting all state in the module.

Possibly related issues

• Issue Disable x/blobstream in v2 #3305: This issue is directly addressed by the PR as it involves disabling the blobstream module in v2, which aligns with the changes made in app.go and upgrade_test.go. The PR seems to be part of the implementation for this issue.

---

Recent Review Details

Configuration used: .coderabbit.yaml
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 05b3d9e and 5e8a96b.

Files selected for processing (2)

• app/app.go (1 hunks)
• app/test/upgrade_test.go (4 hunks)

Additional comments not posted (3)

app/test/upgrade_test.go (2)

24-24: Added import statement for logging.

This import is necessary for enhanced logging capabilities within the test suite.

---

101-123: New function to verify the removal of blobstream parameters in version 2.

This function correctly tests the absence of blobstream parameters in version 2, aligning with the PR's objectives.

app/app.go (1)

458-462: Removal of the blobstream params subspace in the EndBlocker function.

This change is crucial for ensuring that the blobstream functionality is discontinued in version 2 as intended.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

Note: Auto-reply has been disabled for this repository by the repository owner. The CodeRabbit bot will not respond to your replies unless it is explicitly tagged.

• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 1

[coderabbitai]

Duplicate import statement.

- packetforwardtypes "github.com/cosmos/ibc-apps/middleware/packet-forward-middleware/v6/packetforward/types"

This import statement is duplicated and should be removed to clean up the code.

---

Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.

Suggested change

packetforwardtypes "github.com/cosmos/ibc-apps/middleware/packet-forward-middleware/v6/packetforward/types"