-
Notifications
You must be signed in to change notification settings - Fork 297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(statesync): extract app version from snapshot (backport #3871) #3936
Merged
Commits on Oct 2, 2024
-
feat(statesync): extract app version from snapshot (#3871)
Closes #3818 ~~Blocked on celestiaorg/celestia-core#1477 I had to bump the celestia-core depedency to get a feature that I wanted. That implied upgrading Go and cosmos-sdk versions. ## Testing I verified that logs added in this PR show up when state syncing on Mocha. The logs show that the app version provided in the `OfferSnapshot` ABCI method was plumbed through correctly. ``` ./scripts/mocha.sh ... 2:44PM INF Offering snapshot to ABCI app format=2 hash="$�ڢ�\x1b� �zΊ\x15���`��왹\b^G:\x03+ߢޯ" height=2782000 module=statesync 2:44PM INF offering snapshot app_version=2 height=2782000 2:44PM INF mounting keys for snapshot app_version=2 ``` (cherry picked from commit 73793b9) # Conflicts: # .github/workflows/lint.yml # Makefile # docker/txsim/Dockerfile # go.mod # go.sum
Configuration menu - View commit details
-
Copy full SHA for a357db5 - Browse repository at this point
Copy the full SHA a357db5View commit details -
Configuration menu - View commit details
-
Copy full SHA for cf681d4 - Browse repository at this point
Copy the full SHA cf681d4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4f473e3 - Browse repository at this point
Copy the full SHA 4f473e3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 63ff045 - Browse repository at this point
Copy the full SHA 63ff045View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7b10b51 - Browse repository at this point
Copy the full SHA 7b10b51View commit details -
Configuration menu - View commit details
-
Copy full SHA for 189bcf8 - Browse repository at this point
Copy the full SHA 189bcf8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 255b2d1 - Browse repository at this point
Copy the full SHA 255b2d1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7abefe0 - Browse repository at this point
Copy the full SHA 7abefe0View commit details
Commits on Oct 3, 2024
-
Configuration menu - View commit details
-
Copy full SHA for ad1f3b3 - Browse repository at this point
Copy the full SHA ad1f3b3View commit details -
Configuration menu - View commit details
-
Copy full SHA for ac0e7fc - Browse repository at this point
Copy the full SHA ac0e7fcView commit details -
Configuration menu - View commit details
-
Copy full SHA for 74ae7bb - Browse repository at this point
Copy the full SHA 74ae7bbView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.