Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(statesync): extract app version from snapshot (backport #3871) #3936

Merged
merged 11 commits into from
Oct 4, 2024

Commits on Oct 2, 2024

  1. feat(statesync): extract app version from snapshot (#3871)

    Closes #3818
    ~~Blocked on celestiaorg/celestia-core#1477
    
    I had to bump the celestia-core depedency to get a feature that I
    wanted. That implied upgrading Go and cosmos-sdk versions.
    
    ## Testing
    
    I verified that logs added in this PR show up when state syncing on
    Mocha. The logs show that the app version provided in the
    `OfferSnapshot` ABCI method was plumbed through correctly.
    
    ```
    ./scripts/mocha.sh
    ...
    2:44PM INF Offering snapshot to ABCI app format=2 hash="$�ڢ�\x1b� �zΊ\x15���`��왹\b^G:\x03+ߢޯ" height=2782000 module=statesync
    2:44PM INF offering snapshot app_version=2 height=2782000
    2:44PM INF mounting keys for snapshot app_version=2
    ```
    
    (cherry picked from commit 73793b9)
    
    # Conflicts:
    #	.github/workflows/lint.yml
    #	Makefile
    #	docker/txsim/Dockerfile
    #	go.mod
    #	go.sum
    rootulp authored and mergify[bot] committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    a357db5 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    cf681d4 View commit details
    Browse the repository at this point in the history
  3. resolve merge conflicts

    rootulp committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    4f473e3 View commit details
    Browse the repository at this point in the history
  4. fix: unit test for v3

    rootulp committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    63ff045 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    7b10b51 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    189bcf8 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    255b2d1 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    7abefe0 View commit details
    Browse the repository at this point in the history

Commits on Oct 3, 2024

  1. fix: deduplicate tests

    rootulp committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    ad1f3b3 View commit details
    Browse the repository at this point in the history
  2. fix: lint

    rootulp committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    ac0e7fc View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    74ae7bb View commit details
    Browse the repository at this point in the history