Remove cosmos/keyring #548
Conversation
cosmos/keyring hasn't pulled upstream changes from 99designs/keyring yet and the latest release of 99designs/keyring (1.2.1) appears to contain a fix for MacOS warnings: 99designs/keyring#107 Links - https://github.com/cosmos/keyring/tags - https://github.com/99designs/keyring/releases/tag/v1.2.1 `make test` passes after this change and it looks like other Cosmos chains don't need this replace: - https://github.com/osmosis-labs/osmosis/blob/main/go.mod#L274-L285= - https://github.com/CosmosContracts/juno/blob/main/go.mod#L178-L182= Does anyone know if it's still necessary? I couldn't find the justification in celestiaorg#127 which added it.
|
cc @evan-forbes |
|
I don't have a mac to test, but this is plenty good enough for me cosmos/cosmos-sdk#12576 we merge this so that we don't have to wait for the next cosmos-sdk upgrade I think |
|
cosmos/cosmos-sdk#12576 merged but I don't think this PR is ready b/c it won't resolve warnings on macOS until we perform a similar I'd rather not add a direct dependency in celestia-app on keyring v1.2.1 b/c it isn't a true direct dependency of this repo. Defer to @evan-forbes on our strategy for upgrading celestiaorg/cosmos-sdk. Options I can see:
|
|
Yeah, we can just cherry pick those changes in our fork's v0.46.x-celestia branch (which is currently based off of the v0.46.0-beta2 tag) |
|
Blocked on a release of https://github.com/celestiaorg/cosmos-sdk |
|
Based on cosmos/cosmos-sdk#12707 it looks like it will be included in v0.46.0 so agreed, thanks @evan-forbes ! |
|
On second thought, I think we still want to remove the |
|
Status: still blocked on a release of https://github.com/celestiaorg/cosmos-sdk |
|
Release was cut: https://github.com/celestiaorg/cosmos-sdk/releases/tag/v1.2.0-sdk-v0.46.0 Will update this PR after #472 merges |
rootulp
added
dependencies
Resolves #538
cosmos/keyring hasn't pulled upstream changes from 99designs/keyring yet and the latest release of 99designs/keyring (1.2.1) appears to contain a fix for MacOS warnings: 99designs/keyring#107
Links
make testpasses after this change and it looks like other Cosmos chains don't need this replace:Does anyone know if it's still necessary? I couldn't find the justification in #127 which added it.