Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

git sync #180

Closed
tac0turtle opened this issue Mar 5, 2021 · 4 comments
Closed

git sync #180

tac0turtle opened this issue Mar 5, 2021 · 4 comments
Labels
T:tendermint Type: upstream tendermint changes we want

Comments

@tac0turtle
Copy link
Contributor

tac0turtle commented Mar 5, 2021

Summary

After we have migrated the current merged tendermint version to 0.34.x line I would suggest we use https://github.com/marketplace/actions/github-repo-sync to automatically keep the repo in sync.

For the merging of 0.34.x into LL there are two options.

  • Manually merging and deleting commits in repo
  • Cherry pick the LL changes onto 0.34.x and push that to master.

Is there a preference?

@liamsi
Copy link
Member

liamsi commented Mar 5, 2021

OK, so git-sync makes sure that branches here are in sync with upstream. That would be very helpful, e.g. to sync the release branches. This would be cool for all forks we are using (go-ipfs etc).

Manually merging and deleting commits in repo

I think I'm slightly in favour of this option as it keeps the current history (minus very few commits) in place. But honestly, whatever is simpler to use works.

@tac0turtle
Copy link
Contributor Author

Will look at how many LL commits there are. If it's not many I will try my luck 😄

@liamsi
Copy link
Member

liamsi commented Mar 7, 2021

It shouldn't be too crazy. @evan-forbes might appreciate if he could participate in this somehow. Maybe we could do a short pair-programming session for this?

@liamsi liamsi added the T:tendermint Type: upstream tendermint changes we want label Mar 10, 2021
@liamsi liamsi mentioned this issue Jun 2, 2021
17 tasks
@liamsi liamsi mentioned this issue Aug 13, 2021
31 tasks
@liamsi
Copy link
Member

liamsi commented Dec 8, 2021

Feel free to reopen if still relevant @evan-forbes.

@liamsi liamsi closed this as completed Dec 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T:tendermint Type: upstream tendermint changes we want
Projects
None yet
Development

No branches or pull requests

2 participants