Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix overwriting of split message shares #250

Closed
evan-forbes opened this issue Mar 25, 2021 · 0 comments · Fixed by #251
Closed

Fix overwriting of split message shares #250

evan-forbes opened this issue Mar 25, 2021 · 0 comments · Fixed by #251
Assignees
@evan-forbes

Comments

@evan-forbes
Copy link
Member

There's a bug when splitting message shares into smaller MsgShareSize sized results. It ends up overwriting all the appended shares. We should fix it and include a quick test to make sure that it won't happen in the future.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@evan-forbes evan-forbes

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix overwrite bug celestiaorg/celestia-core
1 participant
@evan-forbes