Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ipfs: retrieving data does not work with large(r) blocks #330

Closed
liamsi opened this issue May 13, 2021 · 2 comments
Closed

ipfs: retrieving data does not work with large(r) blocks #330

liamsi opened this issue May 13, 2021 · 2 comments
Labels
C:data-availability Component: Data Availability Proofs C:dht DHT and p2p related issues (IPFS mostly) C:ipld Access to the IPLD merkle dag T:Bug Type: Bug (confirmed)

Comments

@liamsi
Copy link
Member

liamsi commented May 13, 2021

While testing with the DAS light client (#323) we discovered the following behavior:

Sampling, or more general, reading data from another node that had previously called PutBlock only succeeds for small blocks (smaller than 16 kb?).

I don't know the reason yet. @Wondertan started working on a unit test for this that confirms this behavior even when using a mock network and two ipfs nodes.

This needs to be fixed independently from the light client.

2021-05-13 21 28 58

@liamsi liamsi added T:Bug Type: Bug (confirmed) C:data-availability Component: Data Availability Proofs C:dht DHT and p2p related issues (IPFS mostly) C:ipld Access to the IPLD merkle dag labels May 13, 2021
@liamsi
Copy link
Member Author

liamsi commented May 21, 2021

The issue was not this (celestiaorg/nmt#37 happened only during tests) but #336 (fixed by @evan-forbes). Sampling works just fine now but we should still add tests using mock ipfs nodes and e2e tests as well.

For one such mock test see: 1522021#diff-39653ba45e0af8a1a11577bda9cf5b939d78758cebe07da377470aaaba2e0b1aR307

@liamsi
Copy link
Member Author

liamsi commented May 23, 2021

closing in favor of #349 which is only about improving the tests

@liamsi liamsi closed this as completed May 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C:data-availability Component: Data Availability Proofs C:dht DHT and p2p related issues (IPFS mostly) C:ipld Access to the IPLD merkle dag T:Bug Type: Bug (confirmed)
Projects
None yet
Development

No branches or pull requests

1 participant