Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix panic bug in dummyapp and kvstore caused by #372 #385

Closed
evan-forbes opened this issue Jun 2, 2021 · 1 comment
Closed

Fix panic bug in dummyapp and kvstore caused by #372 #385

evan-forbes opened this issue Jun 2, 2021 · 1 comment
Assignees
@evan-forbes
Labels
T:Bug Type: Bug (confirmed)

Comments

@evan-forbes
Copy link
Member

evan-forbes commented Jun 2, 2021 •
edited
Loading

PR #372 added the DataAvailabilityHeader to BlockMeta, which causes the dummyapp and kvstore test apps to panic when they attempt to catch up with tendermint during this handshake because there's no DataAvailabilityHeader in the BlockMeta at height 1. I'm still trying to figure out exactly why that's the case, as the DataAvailabilityHeader is saved properly with every call of store.SaveBlock
@evan-forbes evan-forbes added the T:Bug Type: Bug (confirmed) label Jun 2, 2021
@evan-forbes evan-forbes self-assigned this Jun 2, 2021
@evan-forbes
Copy link
Member Author

I'm a bigger dummy than the dummyapp lol. There was preexisting genesis state on my local machine, just had to call ./dummyapp unsafe-reset-all. Not a bug, just user error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@evan-forbes evan-forbes

Labels
T:Bug Type: Bug (confirmed)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@evan-forbes