Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor remaining changes to tendermint to be more isolated #505

Closed
2 tasks
Tracked by #491
evan-forbes opened this issue Aug 20, 2021 · 2 comments
Closed
2 tasks
Tracked by #491

Refactor remaining changes to tendermint to be more isolated #505

evan-forbes opened this issue Aug 20, 2021 · 2 comments

Comments

@evan-forbes
Copy link
Member

evan-forbes commented Aug 20, 2021

Summary

Refactor modifications to our fork of tendermint to make pulling changes from upstream easier.

Details

One of the goals of our recent decision to reduce the scope of the modifications to our fork of tendermint is to allow for easier pulling of changes from upstream. To further this goal, we should also refactor the remaining necessary changes so that they interfere with tendermint code as little as possible. This will likely mean decoupling existing methods from certain types, and possibly even moving them into their own packages.

Action Items

References

tracking issue #491
ADR #504

@Wondertan
Copy link
Member

@evan-forbes, I didn't check the ADR yet but as part of #296 and celestiaorg/celestia-node#21 I want to extract DAHeader in a separate thing, so part of the issue is on me. If you remember I already did some work towards this in #427.

@evan-forbes
Copy link
Member Author

closed by the merging of #534

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants