Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor DAH generation to give the user more control over what happens to the EDS #538

Closed
1 task
evan-forbes opened this issue Sep 21, 2021 · 2 comments · Fixed by #539 or #534
Closed
1 task
Assignees

Comments

@evan-forbes
Copy link
Member

Summary

Currently the extended data square is being garbage collected after it is created during the generation of a new DataAvailabilityHeader. We should make it so that this decision is not forced on the user.

Details

The user (celestia-node) might want to save the extended data square, so we should change how we generate DataAvailabilityHeaders to allow that to occur

Action Items

  • Break up NewDataAvailabilityHeader func into two pieces
@liamsi
Copy link
Member

liamsi commented Sep 22, 2021

Am I understanding this correctly: this is simply about exposing a method that can be used as a library in Celestia node? Or is there more to it?

@evan-forbes
Copy link
Member Author

whoops, must have missed this comment, but I think we covered it in #539

also can close w/ the merge of #534

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants