Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make timeouts dynamic #939

Open
Tracked by #1256 ...
evan-forbes opened this issue Jan 13, 2023 · 9 comments
Open
Tracked by #1256 ...

Make timeouts dynamic #939

evan-forbes opened this issue Jan 13, 2023 · 9 comments
Labels
WS: Big Blonks 🔭 Improving consensus critical gossiping protocols

Comments

@evan-forbes
Copy link
Member

We expected mocha to have inconsistent block times due to its long proposal timeout, but we should not expect as many consecutive block producers as we're seeing. We need to investigate the cause of both, along with collecting more data to set better default timeouts.

@evan-forbes
Copy link
Member Author

I did some hacking over the weekend and made the timeout commit relative, meaning that it accounted for the time already used in that round. It seems to work as expected, and we end up with more consistent block times. This might be something that we want to pursue after further analysis.

@evan-forbes evan-forbes self-assigned this Feb 6, 2023
@evan-forbes evan-forbes changed the title Investigate inconsistent block times and frequent consecutive block producers on mocha Investigate inconsistent block times Feb 6, 2023
@evan-forbes
Copy link
Member Author

changing this issue to only investigate and fix the inconsistent block times, then splitting off the repeating block producers into a different issue

@cmwaters
Copy link
Contributor

What's remaining of this issue?

@evan-forbes
Copy link
Member Author

What's remaining of this issue?

try out the latest change on mocha imo

@evan-forbes
Copy link
Member Author

to update this, I think we have a good understanding of what is causing the variable block times, and we have decided that we are not pursing a temporary solution. Instead, we will either use protocol enforced block times or separate the block from the square and let comet come to consensus as quickly as possible

@evan-forbes evan-forbes reopened this Feb 26, 2024
@evan-forbes evan-forbes added the WS: Big Blonks 🔭 Improving consensus critical gossiping protocols label Feb 26, 2024
@evan-forbes evan-forbes changed the title Investigate inconsistent block times Make timeouts dynamic May 3, 2024
@evan-forbes evan-forbes added P:High Priority High and removed T:investigate Further investigation needed labels May 3, 2024
@evan-forbes
Copy link
Member Author

we're reprioritizing this issue, we should have the ability to change the timeouts so that we can spend more time gossiping while still having consistent block times.

@evan-forbes evan-forbes removed their assignment May 6, 2024
@evan-forbes
Copy link
Member Author

blocked by #1333

@cmwaters
Copy link
Contributor

I've worked on this prototype (#1342) to illustrate using a model based approach to having dynamic timeouts which I think would be the simplest as most effective solution to stable block times

@liamsi
Copy link
Member

liamsi commented Jul 2, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
WS: Big Blonks 🔭 Improving consensus critical gossiping protocols
Projects
None yet
Development

No branches or pull requests

3 participants