Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): Bump github.com/tendermint/tm-db from 0.6.3 to 0.6.4 #159

Merged

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Feb 9, 2021

Bumps github.com/tendermint/tm-db from 0.6.3 to 0.6.4.

Release notes

Sourced from github.com/tendermint/tm-db's releases.

v0.6.4

https://github.com/tendermint/tm-db/blob/v0.6.4/CHANGELOG.md#064

Changelog

Sourced from github.com/tendermint/tm-db's changelog.

0.6.4

2021-02-09

Bump protobuf to 1.3.2 and grpc to 1.35.0.

Commits
  • 6f9a08c update changelog for v0.6.4 (#150)
  • 4de5f6b CODEOWNERS: remove erikgrinaker (#148)
  • 9f5cde0 build(deps): bump google.golang.org/grpc from 1.33.2 to 1.35.0 (#143)
  • c606a78 build(deps): bump github.com/stretchr/testify from 1.6.1 to 1.7.0 (#142)
  • 0438145 build(deps): bump github.com/gogo/protobuf from 1.3.1 to 1.3.2 (#140)
  • f2b292d testing: docker deployment (#144)
  • 3157a92 changelog: update with 0.5.2 release (#138)
  • See full diff in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [github.com/tendermint/tm-db](https://github.com/tendermint/tm-db) from 0.6.3 to 0.6.4.
- [Release notes](https://github.com/tendermint/tm-db/releases)
- [Changelog](https://github.com/tendermint/tm-db/blob/master/CHANGELOG.md)
- [Commits](tendermint/tm-db@v0.6.3...v0.6.4)

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Feb 9, 2021

Dependabot tried to add @melekes, @tessr and @erikgrinaker as reviewers to this PR, but received the following error from GitHub:

POST https://api.github.com/repos/lazyledger/lazyledger-core/pulls/159/requested_reviewers: 422 - Reviews may only be requested from collaborators. One or more of the users or teams you specified is not a collaborator of the lazyledger/lazyledger-core repository. // See: https://docs.github.com/rest/reference/pulls#request-reviewers-for-a-pull-request

@dependabot dependabot bot added the T:dependencies Type: Pull requests that update a dependency file label Feb 9, 2021
@liamsi
Copy link
Member

liamsi commented Feb 18, 2021

This mainly bumps protobuf to 1.3.2 and grpc to 1.35.0. @evan-forbes would that have any side-effect on ll-app? I do remember updating the version led to some hickups with the generated proto files?

Looking at https://github.com/lazyledger/lazyledger-app/pull/21/files#diff-33ef32bf6c23acb95f5902d7097b7a1d5128ca061167ec0716715b0b9eeaa5f6 we use grpc v1.33.2 and gogo/protobuf v1.3.2-alpha.regen.4 there.

@evan-forbes
Copy link
Member

evan-forbes commented Feb 18, 2021

The cosmos-sdk tests fail when using google.golang.org/grpc v1.35.0, and we run into that super weird non deterministic marshaling bug. Using v1.35.0 is working with the app AFAICT, but I'm guessing if we dug deeper into the app, we'd run into to similar issues.

@tac0turtle
Copy link
Contributor

you need to put a replace statement in the bottom of the go.mod to make it work correctly

replace google.golang.org/grpc => google.golang.org/grpc v1.33.2

@evan-forbes
Copy link
Member

evan-forbes commented Feb 18, 2021

@liamsi and I briefly discussed using replace after finding 1.34.0 was causing the weird bug, and decided to downgrade ll-core instead for the time being, but yeah we're going to have to if we update here. That seems like the best option atm.

@liamsi liamsi removed the request for review from musalbas February 18, 2021 21:02
@liamsi
Copy link
Member

liamsi commented Feb 18, 2021

you need to put a replace statement in the bottom of the go.mod to make it work correctly

replace google.golang.org/grpc => google.golang.org/grpc v1.33.2

Interesting, so we bump the grpc version only to use the replace to downgrade again? Sounds a bit weird but probably worth it to update the protobuf version (as it contains that "skippy peanut butter" fix).

Copy link
Member

@liamsi liamsi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

As Marko mentioned we need to add a replace directive in the SDK / ll-app.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T:dependencies Type: Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants