Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ipld: Consolidate parameters used for square size. #114

Closed
Tracked by #21
renaynay opened this issue Oct 6, 2021 · 2 comments
Closed
Tracked by #21

ipld: Consolidate parameters used for square size. #114

renaynay opened this issue Oct 6, 2021 · 2 comments
Labels
area:ipld IPLD plugin good first issue Good for newcomers

Comments

@renaynay
Copy link
Member

renaynay commented Oct 6, 2021 •
edited
Loading

In the IPLD plugin, there's a parameter extendedRowOrColumnSize hardcoded (to avoid importing the const) at 2*128 which was chosen arbitrarily likely because it's reasonable (somewhere around 1-4 MB). It's important that the parameters aren't different in other parts the celestia codebases.

Ref
@renaynay renaynay added the area:ipld IPLD plugin label Oct 6, 2021
@Wondertan
Copy link
Member

This should be resolved together with refactoring supporting the move to a new ipld related stuff repo #21 or #111

@renaynay
Copy link
Member Author

Yeah let's link to this issue in #21 as a TODO item, it will look nice.

@Wondertan Wondertan mentioned this issue Oct 25, 2021
Closed
5 tasks
@renaynay renaynay added the good first issue Good for newcomers label Apr 26, 2022
@Bidon15 Bidon15 closed this as completed Jul 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area:ipld IPLD plugin good first issue Good for newcomers
Projects
No open projects
Celestia Node
Archived in project
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Bidon15 @Wondertan @renaynay