share/p2p/peers: invalid hash error reported as blacklisted peers

[Wondertan]

Here we report peers being blacklisted, when in fact they are not because of this line

[Wondertan]

cc @walldiss

[walldiss]

Metrics are indicating blacklisting events happen, even when real blacklisting is skipped. It is done for monitoring purposes, to allow safe investigation of blacklisting.

[Wondertan]

It's confusing to see blacklisted peers without this feature being enabled.

[walldiss]

Hm, so it is probably metric or dashboard naming issue. The metric is supposed shows amount of blacklisting events being triggered, rather then amount of actually blacklisted peers.

[walldiss]

One suggestion for resolving this issue and #2702 would be to create subcomponent dedicated for blacklisting from all of our components. It will allow us to create metrics for amount of actual blacklisting events, amount of blacklisted peers and we also can create API to allow blacklist control (Get, Add, Delete etc.) Let me know if it sounds good, so I'll make a proper issue for it