Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request]: expose prove_shares and data_root_inclusion_proof in node API #3364

Open
liamsi opened this issue May 3, 2024 · 9 comments
Assignees
Labels
area:api Related to celestia-node API v0.15.0 Intended for v0.15.0 release

Comments

@liamsi
Copy link
Member

liamsi commented May 3, 2024

Implementation ideas

These two methods are important for integrations/blobstream:
celestiaorg/celestia-app#3421 (comment)

First step could be to expose these two methods in app and simply proxy them in the node API. Then, they could be moved to node entirely.

@liamsi liamsi added the enhancement New feature or request label May 3, 2024
@github-actions github-actions bot added the external Issues created by non node team members label May 3, 2024
@liamsi liamsi added area:api Related to celestia-node API enhancement New feature or request and removed enhancement New feature or request external Issues created by non node team members labels May 3, 2024
@Wondertan
Copy link
Member

Eventually, proxying will be replaced by the work @rach-id is doing which will compute these proofs solely relying on DA node functionality.

@liamsi
Copy link
Member Author

liamsi commented May 5, 2024

Yes, agreed. that's why the OP mentions two steps: 1) proxying and 2) fold/move that functionality entirely into node.

@renaynay renaynay added needs:triage area:api Related to celestia-node API and removed enhancement New feature or request area:api Related to celestia-node API labels May 6, 2024
@renaynay
Copy link
Member

renaynay commented May 7, 2024

This will not make it to v0.14.0, but may be a part of v0.15.0

@renaynay
Copy link
Member

renaynay commented May 7, 2024

@liamsi @Bidon15

I don't think this feature will be ready in time to land in v0.14.0 but that means it would have to be a part of v0.15.0 which may be a couple months out.

Please confirm that this is alright.

@renaynay renaynay added the v0.15.0 Intended for v0.15.0 release label May 7, 2024
@Bidon15
Copy link
Member

Bidon15 commented May 7, 2024

@liamsi @Bidon15

I don't think this feature will be ready in time to land in v0.14.0 but that means it would have to be a part of v0.15.0 which may be a couple months out.

Please confirm that this is alright.

Totally fine for me and thanks for the heads-up 🙏 👑

@liamsi
Copy link
Member Author

liamsi commented May 7, 2024

If it is fine for Viet, than it is fine for me.

it would have to be a part of v0.15.0 which may be a couple months out.

Ideally, we would have an RC including these endpoints that can already be used earlier.

@renaynay
Copy link
Member

renaynay commented May 7, 2024

@liamsi an RC will always come before the release :)

@liamsi
Copy link
Member Author

liamsi commented May 7, 2024

I know. Is a RC with the above also months away though?

@damiannolan
Copy link

related: #3473

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:api Related to celestia-node API v0.15.0 Intended for v0.15.0 release
Projects
None yet
Development

No branches or pull requests

6 participants
@Bidon15 @damiannolan @liamsi @Wondertan @renaynay and others