Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge GetCommitmentProof with GetProof #3582

Open
rach-id opened this issue Jul 19, 2024 · 1 comment · Fixed by #3610
Open

Merge GetCommitmentProof with GetProof #3582

rach-id opened this issue Jul 19, 2024 · 1 comment · Fixed by #3610
Assignees
Labels
external Issues created by non node team members needs:triage

Comments

@rach-id
Copy link
Member

rach-id commented Jul 19, 2024

          The comment Rene referred to is about combining this with `GetProof`. The `GetProof` is originally intended to give blob commitment proof, instead of namespace proof, which is a bug. The namespace proof is already served by the Share module and we don't need to duplicate that.

I would do this change in this PR as we decided to integrate APIs Blobstream needs into the node nicely. I am open to doing that in a separate PR, though, if you think that's better, @rach-id, but as long we release these two PRs together.

Originally posted by @Wondertan in #3470 (comment)

@rach-id rach-id self-assigned this Jul 19, 2024
@github-actions github-actions bot added needs:triage external Issues created by non node team members labels Jul 19, 2024
@rach-id
Copy link
Member Author

rach-id commented Jul 22, 2024

Might also be related to: #2289

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
external Issues created by non node team members needs:triage
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant