You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
New go-da release contains breaking changes and is not backward compatible. All details are tracked in the epic.
The most important change from the celestia-node perspective is change of return type of GetIDs method (not backward compatible!) and addition of SubmitWithOptions. Both changes can be implemented by composition of existing functionality.
Proposed changes
GetIDs
GetIDs implementation currently depends only on blob module - there is no direct way of accessing header. The most intuitive way of resolving this is to modify da.Service to inject header getter function. It can be then used to get block time information.
SubmitWithOptions
SubmitWithOption was introduced to enable the usage of multi-account feature. Because of generic nature of go-da, the new options argument has to be parsed and interpreted by implementation. To keep things simple yet extensible, options value should be a string containing JSON object with keys corresponding to available options, like: KeyName, SignerAddress, FeeGranterAddress. For example:
{"KeyName": "secret_key"}
Those options can be trivially added to NewTxConfig call in da.Service.
The text was updated successfully, but these errors were encountered:
Overview
New go-da release contains breaking changes and is not backward compatible. All details are tracked in the epic.
The most important change from the celestia-node perspective is change of return type of
GetIDs
method (not backward compatible!) and addition ofSubmitWithOptions
. Both changes can be implemented by composition of existing functionality.Proposed changes
GetIDs
GetIDs
implementation currently depends only on blob module - there is no direct way of accessing header. The most intuitive way of resolving this is to modifyda.Service
to inject header getter function. It can be then used to get block time information.SubmitWithOptions
SubmitWithOption
was introduced to enable the usage of multi-account feature. Because of generic nature of go-da, the newoptions
argument has to be parsed and interpreted by implementation. To keep things simple yet extensible,options
value should be a string containing JSON object with keys corresponding to available options, like:KeyName
,SignerAddress
,FeeGranterAddress
. For example:Those options can be trivially added to
NewTxConfig
call inda.Service
.The text was updated successfully, but these errors were encountered: