Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to ipld-prime finally #614

Closed
2 tasks
liamsi opened this issue Apr 11, 2022 · 1 comment
Closed
2 tasks

Update to ipld-prime finally #614

liamsi opened this issue Apr 11, 2022 · 1 comment
Labels
area:ipld IPLD plugin enhancement New feature or request

Comments

@liamsi
Copy link
Member

liamsi commented Apr 11, 2022

After chatting with @Wondertan about this, I think we are finally ready to migrate to ipld-prime.

The main reason is that we are apparently blocked on updating libp2p if we do not also update to ipld-prime. Also, ipfs fully migrated now.

My understanding is that there are two ways to approach this:

  1. Do a full migration using only the abstractions of ipld-prime (time consuming but clean; might take 2-3 weeks).
  2. Switch to ipld-prime but keep using the old abstractions via adapters (faster but less clean; might take a week roughly)

I'll leave it up to Hlib to decide which route to take here.

Just in case, for 2. these are useful resources:

https://github.com/ipld/go-ipld-prime/blob/master/README_migrationGuide.md
https://github.com/ipld/go-ipld-prime/blob/master/storage/README_adapters.md
https://github.com/ipfs/go-ipld-legacy

I also found this very insightful: ipfs/kubo#7976

supersedes: #6
related: #306

Decision

Do Option 1 above as it is substantially faster to implement and unblocks a few things. So this can be split up into two action items that can be turned into separate issues really:

  • Switch to ipld-prime via adapters (testnet)
  • Fully migrate to ipld-prime (incentivized testnet)
@liamsi liamsi added the enhancement New feature or request label Apr 11, 2022
@adlerjohn adlerjohn added the area:ipld IPLD plugin label Apr 11, 2022
@Bidon15
Copy link
Member

Bidon15 commented Nov 15, 2022

Grooming 16/11/2022:

We decided to not go this path after the Berlin mini-onsite in August.

@Bidon15 Bidon15 closed this as not planned Won't fix, can't repro, duplicate, stale Nov 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:ipld IPLD plugin enhancement New feature or request
Projects
No open projects
Archived in project
Development

No branches or pull requests

3 participants