From 07cfb3202ebd57a8505a10f538460bb6d29e69d1 Mon Sep 17 00:00:00 2001 From: Vlad Date: Tue, 8 Aug 2023 12:58:44 +0300 Subject: [PATCH] split global attributes --- nodebuilder/settings.go | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/nodebuilder/settings.go b/nodebuilder/settings.go index c30996d24e..44508ba5e1 100644 --- a/nodebuilder/settings.go +++ b/nodebuilder/settings.go @@ -171,8 +171,13 @@ func initializeMetrics( sdk.WithReader(sdk.NewPeriodicReader(exp, sdk.WithTimeout(2*time.Second))), sdk.WithResource(resource.NewWithAttributes( semconv.SchemaURL, - semconv.ServiceNamespaceKey.String(nodeType.String()), - semconv.ServiceNameKey.String(fmt.Sprintf("%s/%s", network.String(), peerID.String()))))) + // ServiceNamespaceKey and ServiceNameKey will be concatenated into single attribute with key: + // "job" and value: "%service.namespace%/%service.name%" + semconv.ServiceNamespaceKey.String(network.String()), + semconv.ServiceNameKey.String(nodeType.String()), + // ServiceInstanceIDKey will be exported with key: "instance" + semconv.ServiceInstanceIDKey.String(peerID.String()), + ))) lc.Append(fx.Hook{ OnStop: func(ctx context.Context) error { return provider.Shutdown(ctx)