Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Decide on a naming convention for the Ethereum/Orchestrator address in the validator struct #136

Closed
Tracked by #301
rach-id opened this issue May 5, 2022 · 1 comment
Closed
Tracked by #301

Decide on a naming convention for the Ethereum/Orchestrator address in the validator struct #136

rach-id opened this issue May 5, 2022 · 1 comment
Labels
C: QGB good first issue Good for newcomers

Comments

@rach-id
Copy link
Member

rach-id commented May 5, 2022

Currently, the Ethereum address in the validator struct is called EthAddress and the orchestrator address is called Orchestrator. We should decide on a specific name for these which stays consistent with the qgb module on celestia-app side: celestiaorg/celestia-app#303
This was referenced May 5, 2022
Closed
Closed
@rach-id rach-id mentioned this issue Sep 20, 2022
Merged
@rach-id rach-id added the good first issue Good for newcomers label Oct 4, 2022
@rach-id rach-id mentioned this issue Oct 25, 2022
Merged
@evan-forbes
Copy link
Member

per sync discussion, this issue can be closed due to moving to v2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C: QGB good first issue Good for newcomers
Projects
No open projects
Celestia Node
Archived in project
Milestone
No milestone
Development

No branches or pull requests
3 participants
@adlerjohn @rach-id @evan-forbes