Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create validator Ethereum address during simulation tests in a correct way #144

Open
Tracked by #301
rach-id opened this issue May 9, 2022 · 0 comments
Open
Tracked by #301
Labels
C: QGB enhancement New feature or request

Comments

@rach-id
Copy link
Member

rach-id commented May 9, 2022

As of #137 (comment), we're creating a new Ethereum address using the hex representation of the simulated validator account address.
This is currently used as a hack to make the tests pass without having to resort to a massive change: providing a list of Ethereum addresses for each validator that can be used when creating it.
This is an issue because, at first, we were generating a random Ethereum address on each run. The deterministic simulation tests end up with a different app hash on each run. This breaks the test. Thus, we needed a more deterministic way to create an Ethereum address for the validator in question, that would be the same on each run.
Luckily, we're able to use the validator account address to derive an Ethereum address without having to rewrite the whole simulation and still make the tests pass.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C: QGB enhancement New feature or request
Projects
No open projects
Status: TODO
Development

No branches or pull requests

1 participant