Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

p2p: Change signature of session.getRangeByHeight to use to instead of amount #120

Open
renaynay opened this issue Oct 12, 2023 · 1 comment
Open

p2p: Change signature of session.getRangeByHeight to use to instead of amount #120

renaynay opened this issue Oct 12, 2023 · 1 comment
Labels
good first issue Good for newcomers

Comments

@renaynay
Copy link
Member

We have a discrepancy between the exported method GetRangeByHeight on the exchange and the private one on the session where the private one expects an amount instead of a to value.

We should change getRangeByHeight to take to instead.
@renaynay renaynay added the good first issue Good for newcomers label Oct 12, 2023
@AryanGodara
Copy link
Contributor

Can I work on this issue @renaynay?
I'll write up a quick PR, if no one else is working on this issue :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@renaynay @AryanGodara