Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

p2p/peer_tracker: peerTracker scoring may be too aggressive #130

Open
renaynay opened this issue Oct 31, 2023 · 2 comments
Open

p2p/peer_tracker: peerTracker scoring may be too aggressive #130

renaynay opened this issue Oct 31, 2023 · 2 comments
Assignees
Labels

Comments

@renaynay
Copy link
Member

Running a node on mainnet has shown that even though I have good connectivity (~60 peers), my node's peerTracker only contains 3 tracked peers. It's likely due to aggressive peer scoring. We may need to be more lenient with it as it's better to have more trackedPeers that may have "mid-level" scores instead of only keeping the absolute best (which may be a very small pool).

We need to consider the scoring mechanism and adjust accordingly. We can only start doing this once we have a dashboard for the metrics that have just been implemented so we can make an informed decision.

@vgonkivs
Copy link
Member

We can consider EWMA. It is used in the fintech world, but could be also helpful for us. We discussed this with @Wondertan some time ago

@walldiss
Copy link
Member

We can add minAmount of peer to peer tracker. If amount of connect peers is less than minAmount it should not remove connected peers. It will solve original issue and should be quick to implement and give us time to select and implement smarter scoring arithmetic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants