Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

store: add retries to flushLoop #209

Closed
cristaloleg opened this issue Jun 28, 2024 · 0 comments · Fixed by #211
Closed

store: add retries to flushLoop #209

cristaloleg opened this issue Jun 28, 2024 · 0 comments · Fixed by #211
Assignees
@cristaloleg
Labels
kind:feat

Comments

@cristaloleg
Copy link
Contributor

Currently Store[H].flushLoop will not retry a failed batch, will only increase metric and log the error. Backoff with retries should be much better in this case.

Also, should we do log.Fatal/os.Exit when retries is still unsuccessful?

Based on comment #207 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cristaloleg cristaloleg

Labels
kind:feat
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(store): flush loop retries and backoff celestiaorg/go-header
1 participant
@cristaloleg