Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Naming of test cases is confusing #194

Closed
andrijamitrovic23 opened this issue Jun 23, 2023 · 1 comment · Fixed by #198
Closed

Naming of test cases is confusing #194

andrijamitrovic23 opened this issue Jun 23, 2023 · 1 comment · Fixed by #198
Assignees
Labels

Comments

@andrijamitrovic23
Copy link

First part of naming of test cases in TestCorruptedEdsReturnsErrByzantineData is confusing. There are two possible ways to understand what does the naming refer to, and both of them are not completely right:

  • Bad Row or Column refers to the one Axis that should be returned as a part of the byzData. Trough debugging it has been confirmed that only for the third test case there is a overlapping between a name and the returned axis.

  • Bad Row or Column refers to the corruption of data within a row or a column but this is not true for the fourth test case.

Maybe just use the second part of naming (after “/“) which refers to will the original or extended data be corrupted.

@rootulp
Copy link
Collaborator

rootulp commented Jun 23, 2023

Tagging @distractedm1nd for awareness

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants