win7/32 - busted running EchoServer example #74
Comments
|
This same problem currently exists with celluloid 0.14.1 on Win7/x64, with nio4r v0.5.0. Seems like perhaps it impacts any Windows users wanting to use celluloid-io... 😿 |
|
Here is some my resulting backtrace: |
|
@deadprogram can you confirm this still impacts |
|
This might be a dumb question, why are my unit tests now erroring with the following when running using 0.15.0.pre? |
|
@deadprogram oof! do you have a repro for that? |
|
This is on running tests on https://github.com/hybridgroup/artoo/tree/celluloid-0.15.0.pre by running I am using the following Ruby when running tests: |
|
Hmm, maybe you can try opening another issue for this so we don't clutter the conversation here. That said, you need to run "rake spec", not "rake test" |
|
I was referring to artoo tests not celluloid ones. I will open new issue |
|
Entered separate issue here: celluloid/celluloid#321 I will retest the Win7 issue in a bit as well... |
|
OK confirm the Windows 7 problem in this issue still exists when testing 0.15.0.pre |
|
Confirmed that it fails the same way on Windows 7, also on x64. I am using guard/listen which uses celluloid-io and cannot be used because of this issue. (Issue pushed/voted up) |
|
Have you tried running it with jruby? Its usually working better on Windows for me. |
|
@mechanicalduck can you post a backtrace? Can you try celluloid-io --pre ? (0.16.0.pre2) |
|
Thank you for your quick responses! @Asmod4n: @tarcieri: If interesting: This error occurs in the moment a peer connects to guard/listen. I will install celluloid-io --pre (0.16.0.pre2) as advised and check if the issue still occurs then. With best regards |
|
Issue still persists after upgrading to celluloid-io --pre (0.16.0.pre2): With best regards |
|
There's an open question as to why Windows is causing reentrant locking here. I know nio4r's locking model is kind of shitty. Perhaps it needs to be revisited. Perhaps you should push guard upstream not to use Celluloid::IO until this issue is hammered out on Windows? They're not getting a whole lot of benefit from it at the moment, IMO. |
|
I will post a ticket and proposing to replace Celluloid::IO with native code. @Asmod4n However, JRuby doesn't support building gem native extensions anymore. |
|
JRuby should be able to do it without any native code: https://blogs.oracle.com/thejavatutorials/entry/watching_a_directory_for_changes |
|
So Java natively supports file system notification handling. For using this in guard/listen I would probably have to rewrite the source code |
|
It would be nice to get filesystem monitoring added to nio4r in a cross-platform way. re: this particular bug, I don't have access to a Windows machine or any way to debug it, sorry. @luislavena I don't suppose you have any ideas? 😉 |
|
@mechanicalduck it sounds more like listen could use a java "adapter". Or like @tarcieri said a cross platform way for nio4r to handle it. It's currently a mess to handle file system events in ruby, while libev has ways to do it nicely it has zero windows support afaik, libuv on the other hand has windows support, at least for sockets, dunno for file events. |
|
@tarcieri hello there. I remember (a year ago) when suggested migrate As for Windows testing, I'm working out ways to automate testing for Ruby using AppVeyor: Of course that will not solve manual hacking but is a start 😁 Will take a look and attempt to investigate the deadlock issue. If you folks can provide a simple scenario for me to reproduce, will be great. |
|
Reproducing the deadlock issue:
Side Note: You can always terminate the telnet session with Ctrl - (if you got stuck).
With best regards |
|
+1 |
1 similar comment
|
+1 |
|
same problem here. Win8 / Ruby 2.0.0-481 32bit / celluloid 0.16.0 / celluloid-io 0.16.1 |
|
Just ran into the exact same problem again. Found my own "me too" above, giggled, shook my head, left this message.
|
starts fine but when I connect to it, it crashes..
Also tested code on Ubuntu, works fine..
any ideas...
E, [2013-07-04T10:35:42.466017 #3800] ERROR -- : EchoServer crashed!
ThreadError: deadlock; recursive locking
internal:prelude:8:in
lock' <internal:prelude>:8:insynchronize'C:/Ruby193/lib/ruby/gems/1.9.1/gems/nio4r-0.4.6/lib/nio/selector.rb:34:i
n
deregister' C:/Ruby193/lib/ruby/gems/1.9.1/gems/nio4r-0.4.6/lib/nio/monitor.rb:40:inclose'C:/Ruby193/lib/ruby/gems/1.9.1/gems/celluloid-io-0.14.1/lib/celluloid/io
/reactor.rb:51:in
block in run_once' C:/Ruby193/lib/ruby/gems/1.9.1/gems/nio4r-0.4.6/lib/nio/selector.rb:88:i nblock (2 levels) in select'C:/Ruby193/lib/ruby/1.9.1/set.rb:222:in
block in each' C:/Ruby193/lib/ruby/1.9.1/set.rb:222:ineach_key'C:/Ruby193/lib/ruby/1.9.1/set.rb:222:in
each' C:/Ruby193/lib/ruby/gems/1.9.1/gems/nio4r-0.4.6/lib/nio/selector.rb:87:i nblock in select'internal:prelude:10:in
synchronize' C:/Ruby193/lib/ruby/gems/1.9.1/gems/nio4r-0.4.6/lib/nio/selector.rb:48:i nselect'C:/Ruby193/lib/ruby/gems/1.9.1/gems/celluloid-io-0.14.1/lib/celluloid/io
/reactor.rb:49:in
run_once' C:/Ruby193/lib/ruby/gems/1.9.1/gems/celluloid-0.14.1/lib/celluloid/event ed_mailbox.rb:56:inreceive'C:/Ruby193/lib/ruby/gems/1.9.1/gems/celluloid-0.14.1/lib/celluloid/actor
.rb:173:in
run' C:/Ruby193/lib/ruby/gems/1.9.1/gems/celluloid-0.14.1/lib/celluloid/actor .rb:157:inblock in initialize'C:/Ruby193/lib/ruby/gems/1.9.1/gems/celluloid-0.14.1/lib/celluloid/threa
d_handle.rb:13:in
block in initialize' C:/Ruby193/lib/ruby/gems/1.9.1/gems/celluloid-0.14.1/lib/celluloid/inter nal_pool.rb:59:incall'C:/Ruby193/lib/ruby/gems/1.9.1/gems/celluloid-0.14.1/lib/celluloid/inter
nal_pool.rb:59:in `block in create'
The text was updated successfully, but these errors were encountered: