Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failing test with Solidity 0.8 #1528

Closed
oneeman opened this issue Apr 30, 2021 · 0 comments
Closed

Failing test with Solidity 0.8 #1528

oneeman opened this issue Apr 30, 2021 · 0 comments
Labels
status:archived Issue to be archived theme: housekeeping About making code cleaner, more maintenability, testability, etc

Comments

@oneeman
Copy link
Contributor

oneeman commented Apr 30, 2021

Expected Behavior

Tests should pass when you have current version of Solidity installed

Current Behavior

If you have version 0.8 of solc installed (not the javascript solidity compiled but the C++ version), you get this failure:

--- FAIL: TestSolidityCompiler (0.07s)
   solidity_test.go:47: error compiling source. result map[]: json: cannot unmarshal array into Go struct field .Contracts.Abi of type string
FAIL
FAIL	github.com/ethereum/go-ethereum/common/compiler	0.180s
FAIL

With older versions it passes, and if you don't have it installed the test is skipped so it also passes.

The fix for this is to cherry-pick ethereum/go-ethereum#22092. Once we do that we may also want to have solc installed in our CI setup so that this test can actually run there too.

@oneeman oneeman added blockchain theme: housekeeping About making code cleaner, more maintenability, testability, etc labels Apr 30, 2021
@carterqw2 carterqw2 added triage Issue needs triaging and removed blockchain labels Feb 9, 2023
@carterqw2 carterqw2 added status:archived Issue to be archived and removed triage Issue needs triaging labels Feb 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:archived Issue to be archived theme: housekeeping About making code cleaner, more maintenability, testability, etc
Projects
None yet
Development

No branches or pull requests

2 participants