Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR #1573 broke e2e tests when mycelo isn't used #1626

Closed
oneeman opened this issue Jul 14, 2021 · 0 comments · Fixed by #1629
Closed

PR #1573 broke e2e tests when mycelo isn't used #1626

oneeman opened this issue Jul 14, 2021 · 0 comments · Fixed by #1629
Assignees

Comments

@oneeman
Copy link
Contributor

oneeman commented Jul 14, 2021

Expected Behavior

The e2e tests in celo monorepo should work whether they are configured to use mycelo or not.

Current Behavior

Since PR #1573, the tests no longer work when they aren't configured to do genesis generation using mycelo. I noticed this from their failing in an open RP of mine: celo-org/celo-monorepo#8291. I ran it locally and confirmed that this is because of #1573. What happens is the node errors out with:

Fatal: Failed to register the Ethereum service: no Registry Smart Contract deployed in genesis

Steps to Reproduce Behavior

Run any of the e2e tests in the monorepo without mycelo. You can do this by either checking out the branch from the PR mentioned above, or by yourself changing useMycelo: true to migrate: true in the test you want to run.

System information

Celo
Version: 1.4.0-unstable
Git Commit: 8c3b69ba7545bfc25e2ad89878df272051c89788
Git Commit Date: 20210714
Architecture: amd64
Protocol Versions: [66]
Go Version: go1.16.4
Operating System: darwin
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants