Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Internal EVM calls SBAT emit events #370

Closed
m-chrzan opened this issue Aug 2, 2019 · 2 comments · Fixed by #584
Closed

Internal EVM calls SBAT emit events #370

m-chrzan opened this issue Aug 2, 2019 · 2 comments · Fixed by #584
Assignees

Comments

@m-chrzan
Copy link
Contributor

m-chrzan commented Aug 2, 2019

Expected Behavior

If the inflation factor gets updated when calling debitFrom to pay for a transaction fee with Celo Dollars, an InflationFactorUpdated event should be emitted.

Current Behavior

Haven't checked 100%, but from what I've seen, events from internal EVM calls are likely to be lost. So first step is to confirm this is actually a problem, but wanted to flag this.

@mrsmkl
Copy link
Contributor

mrsmkl commented Oct 25, 2019

Tested by adding an event that is emitted every time debitFrom is called. It shows up in the receipts. Looks like events are added to statedb similarly to changes made into storage.

@mrsmkl
Copy link
Contributor

mrsmkl commented Nov 12, 2019

If there is no associated transaction, the logs will then be gone...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants