Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Users SBAT receive proper HTTP codes for errors #1075

Closed
nambrot opened this issue Sep 23, 2019 · 0 comments · Fixed by #1468
Closed

Users SBAT receive proper HTTP codes for errors #1075

nambrot opened this issue Sep 23, 2019 · 0 comments · Fixed by #1468
Assignees
@nambrot
Labels
enhancement an improvement to an existing feature Priority: P2 Major triaged label for issues that have been assigned a priority

Comments

@nambrot
Copy link
Contributor

nambrot commented Sep 23, 2019 •
edited
Loading

Expected Behavior

We should only process requests that are well-formed and return 422.
If an exception occurs we should return 500

Current Behavior

There is no proper parsing of request parameters.
When exceptions happen, we don't send anything back either.
@nambrot nambrot mentioned this issue Sep 23, 2019
Merged
1 task
@nambrot nambrot changed the title Users SNBAT to send malformed attestation requests Users SBAT receive proper HTTP codes for errors Sep 25, 2019
@nambrot nambrot self-assigned this Oct 15, 2019
@nityas nityas added enhancement an improvement to an existing feature Priority: P2 Major triaged label for issues that have been assigned a priority labels Oct 15, 2019
@nambrot nambrot mentioned this issue Oct 24, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nambrot nambrot

Labels
enhancement an improvement to an existing feature Priority: P2 Major triaged label for issues that have been assigned a priority
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Validate Attestation Requests celo-org/celo-monorepo
2 participants
@nambrot @nityas