Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add integration test for L2 devchain #11138

Open
arthurgousset opened this issue Jul 12, 2024 · 0 comments
Open

Add integration test for L2 devchain #11138

arthurgousset opened this issue Jul 12, 2024 · 0 comments

Comments

@arthurgousset
Copy link
Contributor

arthurgousset commented Jul 12, 2024

Expected Behavior

Running integration tests should pass whether the devchain is L1 or L2:

forge test -vvv \
--match-path "test-sol/integration/*" \
--fork-url $ANVIL_RPC_URL

When that's the case, we should consider:

  1. adding L2 integration tests, and
  2. running both L1 and L2 integration tests on CI
    - name: Run integration tests against L1 devchain
    if: success() || failure()
    run: |
    sudo apt-get update
    sudo apt-get install -y lsof
    source ./scripts/foundry/constants.sh
    echo "Starting L1 from scratch to circumvent Anvil bug"
    source ./scripts/foundry/create_and_migrate_anvil_devchain.sh
    forge test -vvv \
    --match-path "test-sol/integration/*" \
    --fork-url $ANVIL_RPC_URL

Current Behavior

As of #11107, an existing integration test is failing when run against an L2 devchain.

Might be good to create an issue to track adding integration test here.

I briefly looked at the error that happens when running the integration test on L2, and its because RevokeCeloAfterL2TransitionTest assumes that the chain starts on L1 than transitions to L2 within the test.

This causes the validator contract to fail during initialization since devchain L2 is already active.

Originally posted by @soloseng in #11107 (comment)

@arthurgousset arthurgousset changed the title Might be good to create an issue to track adding integration test here. Add integration test for L2 devchain Jul 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant