Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Devs SBAT deploy latest registry in genesis #1119

Closed
timmoreton opened this issue Sep 26, 2019 · 1 comment · Fixed by #1122
Closed

Devs SBAT deploy latest registry in genesis #1119

timmoreton opened this issue Sep 26, 2019 · 1 comment · Fixed by #1122
Assignees
@mrsmkl
Labels
protocol All issues relating to protocol packages

Comments

@timmoreton
Copy link
Contributor

timmoreton commented Sep 26, 2019 •
edited
Loading

Expected Behavior

When generating the genesis block for deploying a testnet in generate_utils.ts, we should automatically determine the code for the latest proxy contract at packages/protocol/contracts/common/Registry.sol. (I'm guessing automatically determining CONTRACT_OWNER_STORAGE_LOCATION is harder)

Current Behavior

We deploy the smart contract code as per PROXY_CONTRACT_CODE in packages/celotool/src/lib/genesis_constants.ts
@timmoreton timmoreton added the protocol All issues relating to protocol packages label Sep 26, 2019
@timmoreton
Copy link
Contributor Author

Also turns out our current deployed registry is out of date :-)

@mrsmkl mrsmkl mentioned this issue Sep 27, 2019
Merged
@snyk-bot snyk-bot mentioned this issue Sep 5, 2021
Open
@lili2311 lili2311 mentioned this issue Sep 18, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mrsmkl mrsmkl

Labels
protocol All issues relating to protocol packages
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Deploying latest proxy code in genesis mrsmkl/celo-monorepo
2 participants
@mrsmkl @timmoreton