Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Texts with our custom font are not vertically centered when lineHeight is set #1242

Closed
jeanregisser opened this issue Oct 8, 2019 · 2 comments
Labels
bug Something isn't working Priority: P2 Major triaged label for issues that have been assigned a priority wallet

Comments

@jeanregisser
Copy link
Contributor

Expected Behavior

Texts should be vertically centered within their bounding box when we are using our custom font (HindSilguri) and lineHeight is set.

Current Behavior

Texts are not vertically centered within their bounding box when their are using our custom font (HindSilguri) and lineHeight is set.

This makes it difficult to center align things vertically.

Example showing the problem (added background color to make it clear):
Screenshot 2019-08-06 at 15 01 37

@jeanregisser jeanregisser changed the title Texts with our custom font are not vertically centered when lineHeight is set. Texts with our custom font are not vertically centered when lineHeight is set Oct 8, 2019
@nityas nityas added bug Something isn't working Priority: P2 Major triaged label for issues that have been assigned a priority labels Oct 14, 2019
@jmrossy
Copy link
Contributor

jmrossy commented Dec 23, 2019

From @jeanregisser on Slack:
there's something off with RN and our custom font, here I'm facing a slight jump in TextInput when there's a placeholder value in it on Android.
With the default font it doesn't happen
I'll leave it for now, but hope we can fix it. Probably linked to the same thing that makes us specify the lineHeight too.

@jeanregisser
Copy link
Contributor Author

This doesn't happen anymore with the font used in the new design. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Priority: P2 Major triaged label for issues that have been assigned a priority wallet
Projects
None yet
Development

No branches or pull requests

3 participants