Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SDK users sbat request a variable number of attestations at once, with a default of 3 #1316

Closed
nityas opened this issue Oct 11, 2019 · 1 comment
Labels
Component: SDK enhancement an improvement to an existing feature Priority: P2 Major stale

Comments

@nityas
Copy link
Contributor

nityas commented Oct 11, 2019

Expected Behavior

per https://github.com/celo-org/celo-labs/issues/80#issuecomment-541174310, we give a caller flexibility to request variable #s of attestations at any point in time, with the ability to

  • Make the default number of attestations requested 3 (optional param with default?), add some documentation explaining the reason for this default and the implications of using a number less than 3.
  • add a function that allows a caller to easily determine if a verified phone number had >= 3 attestations requested at once, or if they were requested spaced out over a long period of time

Current Behavior

What is the current behavior?

@github-actions
Copy link
Contributor

This issue is stale and will be closed in 30 days without activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: SDK enhancement an improvement to an existing feature Priority: P2 Major stale
Projects
None yet
Development

No branches or pull requests

5 participants