Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Users should be able to sign with the same format #1470

Closed
nambrot opened this issue Oct 24, 2019 · 0 comments · Fixed by #1473 · 4 remaining pull requests
Closed

Users should be able to sign with the same format #1470

nambrot opened this issue Oct 24, 2019 · 0 comments · Fixed by #1473 · 4 remaining pull requests
Assignees
@nambrot
Labels
protocol All issues relating to protocol packages

Comments

@nambrot
Copy link
Contributor

nambrot commented Oct 24, 2019

Expected Behavior

We should only use prefixed signatures like https://github.com/ethereum/wiki/wiki/JSON-RPC#eth_sign

Current Behavior

We currently use both prefixed and non-prefixed signatures
@nambrot nambrot added the protocol All issues relating to protocol packages label Oct 24, 2019
@nambrot nambrot self-assigned this Oct 24, 2019
@nambrot nambrot mentioned this issue Oct 24, 2019
Merged
This was referenced Jul 9, 2020
Open
Open
Open
This was referenced Jul 19, 2020
Open
Open
Open
@snyk-bot snyk-bot mentioned this issue Sep 16, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nambrot nambrot

Labels
protocol All issues relating to protocol packages
Projects
None yet
Milestone
No milestone
1 participant
@nambrot