Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stability fee should be zero then kick in automatically after ~18months #1597

Closed
timmoreton opened this issue Nov 6, 2019 · 2 comments
Closed

Stability fee should be zero then kick in automatically after ~18months #1597

timmoreton opened this issue Nov 6, 2019 · 2 comments
Labels
audit Priority: P2 Major protocol All issues relating to protocol packages stake-off-bubble Issues under the Stake Off Engineering Bubble

Comments

@timmoreton
Copy link
Contributor

timmoreton commented Nov 6, 2019 •
edited by asaj
Loading

In StableToken.sol, a stability fee is implemented via the InflationFactor. This inflation factor should remain 1.0 until 18 months after launch, after which it should update every inflationState.updatePeriod seconds
@timmoreton timmoreton added audit protocol All issues relating to protocol packages labels Nov 6, 2019
@BatiGencho BatiGencho self-assigned this Dec 4, 2019
@mcortesi
Copy link
Contributor

We should use block.time to compute time; not block.number

@BatiGencho BatiGencho mentioned this issue Jan 6, 2020
Closed
@nategraf nategraf added the stake-off-bubble Issues under the Stake Off Engineering Bubble label Feb 6, 2020
@nategraf nategraf added the Priority: P2 Major label Feb 6, 2020
@mrsmkl mrsmkl self-assigned this Feb 20, 2020
@mrsmkl
Copy link
Contributor

mrsmkl commented Feb 20, 2020

Looks like the update period is currently 18 months, so the current code should have the required behaviour.

@mrsmkl mrsmkl removed their assignment Feb 20, 2020
@asaj asaj closed this as completed Feb 22, 2020
@snyk-bot snyk-bot mentioned this issue Nov 27, 2020
Open
@snyk-bot snyk-bot mentioned this issue Apr 11, 2022
Open
@snyk-bot snyk-bot mentioned this issue May 13, 2022
Open
@snyk-bot snyk-bot mentioned this issue Jun 22, 2022
Open
@snyk-bot snyk-bot mentioned this issue Jul 24, 2022
Open
This was referenced Sep 22, 2022
Open
Open
@lili2311 lili2311 mentioned this issue Oct 18, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
audit Priority: P2 Major protocol All issues relating to protocol packages stake-off-bubble Issues under the Stake Off Engineering Bubble
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@mrsmkl @timmoreton @mcortesi @asaj @nategraf @BatiGencho