Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Internal audit of parameter validation in contract initialization #1604

Closed
asaj opened this issue Nov 6, 2019 · 0 comments · Fixed by #2813
Closed

Internal audit of parameter validation in contract initialization #1604

asaj opened this issue Nov 6, 2019 · 0 comments · Fixed by #2813
Assignees
@asaj
Labels
audit Priority: P2 Major protocol All issues relating to protocol packages stake-off-bubble Issues under the Stake Off Engineering Bubble

Comments

@asaj
Copy link
Contributor

asaj commented Nov 6, 2019

Expected Behavior

All proxied contracts should use appropriate setters in initialize, those setters should validate the provided parameters are sane (e.g. addresses not equal to zero)

Current Behavior

Unclear
@asaj asaj added protocol All issues relating to protocol packages audit labels Nov 6, 2019
@BatiGencho BatiGencho mentioned this issue Jan 6, 2020
Closed
@nategraf nategraf added the stake-off-bubble Issues under the Stake Off Engineering Bubble label Feb 6, 2020
@nategraf nategraf added the Priority: P2 Major label Feb 6, 2020
@asaj asaj self-assigned this Feb 22, 2020
@mcortesi mcortesi mentioned this issue Feb 23, 2020
Merged
@snyk-bot snyk-bot mentioned this issue Nov 27, 2020
Open
@snyk-bot snyk-bot mentioned this issue Apr 11, 2022
Open
@snyk-bot snyk-bot mentioned this issue May 13, 2022
Open
@snyk-bot snyk-bot mentioned this issue Jun 22, 2022
Open
@snyk-bot snyk-bot mentioned this issue Jul 24, 2022
Open
This was referenced Sep 22, 2022
Open
Open
@lili2311 lili2311 mentioned this issue Oct 18, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@asaj asaj

Labels
audit Priority: P2 Major protocol All issues relating to protocol packages stake-off-bubble Issues under the Stake Off Engineering Bubble
Projects
None yet
Milestone
No milestone
3 participants
@asaj @nategraf @BatiGencho