Web3 usages should handle errors returned when view calls revert

[nategraf]

Expected Behavior

When a view call reverts it should be handled as an error.

Current Behavior

Due to ethereum/go-ethereum#19027 the eth_call RPC returns the error code as the return value which gets interpreted by web3 be a valid value. This includes either casting it to a number or boolean which makes it difficult to differentiate from valid values.

This was discovered during the Baklava hotfix process when one of the view calls used by the CLI would revert and lead to the CLI reporting the hotfix was passing, when in fact it was not. This could lead to much more serious issues if not addressed.

[github-actions]

This issue is stale and will be closed in 30 days without activity