Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slashing reward recipient receives double rewards from Downtime and DoubleSigning #2943

Closed
lucasege opened this issue Feb 25, 2020 · 1 comment
Labels
quick-fix Things that should be quick fixes- Good for first issues & ramping up stale

Comments

@lucasege
Copy link
Contributor

Expected Behavior

Slashing reporter should receive reward worth of nonvoting lockedgold after a successful slash

Current Behavior

Slashing reporter will receive reward * 2 worth of nonvoting lockedgold.

Cause: SlasherUtil calls lockedgold.slash once on the "bad actor" and once on their group, both calls with the same recipient and reward, meaning recipient receives reward twice.

Proposed solution: easiest solution is to just make it clear that slashingIncentives.reward should be 1/2 of the proposed reward, or change setSlashingIncentives to set reward to 1/2 of the provided reward param.

@lucasege lucasege added bug Something isn't working quick-fix Things that should be quick fixes- Good for first issues & ramping up and removed bug Something isn't working labels Feb 25, 2020
@github-actions
Copy link
Contributor

This issue is stale and will be closed in 30 days without activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
quick-fix Things that should be quick fixes- Good for first issues & ramping up stale
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant