Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tech debt in ReleaseGold and Election #3500

Closed
lucasege opened this issue Apr 20, 2020 · 0 comments · Fixed by #3940
Closed

Tech debt in ReleaseGold and Election #3500

lucasege opened this issue Apr 20, 2020 · 0 comments · Fixed by #3940
Assignees
@37ng
Labels
quick-fix Things that should be quick fixes- Good for first issues & ramping up tech-debt

Comments

@lucasege
Copy link
Contributor

Expected Behavior

There should be less tech debt

Current Behavior

In Election:forceDecrementVotes the last line is return value.sub(info.remainingValue); however info.remainingValue is required to be zero.

The computation of getRemainingLockedBalance in ReleaseGold. There is an if that the contract is an account before computing the lockedgold pending but not for the locked part. This should all be in the same if block
@lucasege lucasege added tech-debt quick-fix Things that should be quick fixes- Good for first issues & ramping up labels Apr 20, 2020
@37ng 37ng assigned 37ng and unassigned 37ng Jun 1, 2020
@37ng 37ng linked a pull request Jun 1, 2020 that will close this issue
Fixing Tech debt in ReleaseGold and Election #3940
Merged
@37ng 37ng self-assigned this Jun 1, 2020
@37ng 37ng closed this as completed in #3940 Jun 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@37ng 37ng

Labels
quick-fix Things that should be quick fixes- Good for first issues & ramping up tech-debt
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixing Tech debt in ReleaseGold and Election celo-org/celo-monorepo
2 participants
@lucasege @37ng