Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edge cases around invite code messaging #4944

Closed
tarikbellamine opened this issue Sep 2, 2020 · 7 comments
Closed

Edge cases around invite code messaging #4944

tarikbellamine opened this issue Sep 2, 2020 · 7 comments
Assignees

Comments

@tarikbellamine
Copy link
Contributor

tarikbellamine commented Sep 2, 2020

Expected Behavior

A user is able to easily view and message their invite code on a messenger of their choice after sending a successful invite transaction.

Current Behavior

Two known edge cases:

  • Non-native messenger apps (e.g., Signal) are opened but populated with blank message bodies
  • Attempting to send via WhatsApp when the recipient is not a n existing user of WhatsApp returns an error

Both these edge cases result in the invite code not being viewable for the user.

Potential solution: have a fallback option when messaging fails that displays an easily copy-able invite code. Or a more holistic approach is to have somewhere in the app users can view (and potentially reclaim) sent invites.

@Lss-Ankit
Copy link

Hi @tarikbellamine FYI: one similar bug is in open status: #1308

@tarikbellamine
Copy link
Contributor Author

Thank you for flagging @Lss-Ankit. I will close that issue for now as we no longer allow messaging through those channels.

@Lss-Ankit
Copy link

Okay thanks for the updates @tarikbellamine For whats app i have tried if invited user is not in whatsApp then whatsApp gives error that user is not in whatsApp. it seems expected but when i came back to valora app, invitation fees $0.25 is cuts along with escrow payment sent. is it expected or i need to file a separate bug for the same.
Thanks!

@tarikbellamine
Copy link
Contributor Author

No need for a new bug, I think this will covers it.

@Lss-Ankit
Copy link

Okay @tarikbellamine thanks for the update.

@nityas
Copy link
Contributor

nityas commented Dec 1, 2020

closing out as new invite flow resolves

@nityas nityas closed this as completed Dec 1, 2020
@Lss-Ankit
Copy link

Hi @nityas We have verified this issue on on latest Android internal build v1.6.0(1004294326) and Test Flight build v1.6.0(37) and found issue is fixed
-User is able to easily view and message their invite code on a messenger

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants