Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Profile Photos & Names with CIP8 #5431

Closed
jeanregisser opened this issue Oct 19, 2020 · 0 comments
Closed

Profile Photos & Names with CIP8 #5431

jeanregisser opened this issue Oct 19, 2020 · 0 comments
Assignees
@gnardini @isabellewei
Labels
commit Component: Feed & Notifications epic feature Feature requests Priority: P2 Major wallet
Milestone
Milestone 7

Comments

@jeanregisser
Copy link
Contributor

jeanregisser commented Oct 19, 2020 •
edited
Loading

NOTE: Full CIP08 implementation is not a GA Blocker.

What's important about this?

The original plan to fix this along with profile picture can be seen in https://celo-org.slack.com/archives/CL7BVQPHB/p1602523078235800

Definition of "done"

No "Unknown" are displayed in the feed, and names set by users are used instead.

What's involved in doing this work?

  • Build new UI screens and elements
  • Integration with a new CIP8 backend for Valora
  • Make sure it works in a performant way (especially on the feed)

Open questions
@jeanregisser jeanregisser added this to the Milestone 7 milestone Oct 19, 2020
@jeanregisser jeanregisser added Priority: P2 Major and removed Priority: P2 Major Priority: P1 Critical labels Oct 21, 2020
This was referenced Nov 30, 2020
Closed
Closed
@nityas nityas closed this as completed Dec 13, 2020
This was referenced Jun 21, 2022
Open
Open
@snyk-bot snyk-bot mentioned this issue Sep 27, 2022
Open
@lili2311 lili2311 mentioned this issue Sep 25, 2023
Open
@leojoy95 leojoy95 mentioned this issue Dec 6, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gnardini gnardini

@isabellewei isabellewei

Labels
commit Component: Feed & Notifications epic feature Feature requests Priority: P2 Major wallet
Projects
None yet
Milestone
Milestone 7
Development

No branches or pull requests
4 participants
@jeanregisser @nityas @gnardini @isabellewei