Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dev SBAT to turn Geth sync on/off #68

Closed
ashishb opened this issue Jul 19, 2019 · 3 comments
Closed

Dev SBAT to turn Geth sync on/off #68

ashishb opened this issue Jul 19, 2019 · 3 comments
Labels
enhancement an improvement to an existing feature investigate Priority: P2 Major triaged label for issues that have been assigned a priority wallet

Comments

@ashishb
Copy link
Contributor

ashishb commented Jul 19, 2019

Expected Behavior

Dev SBAT to turn Geth sync on/off
For example, turn sync on when the app is foregrounded and off when the app is backgrounded. Or sync less eagerly on cellular than unmetered Wi-Fi.

Current Behavior

Geth sync runs while the app is running. In ad-hoc testing, @jmrossy found that the app uses ~1MB per minute due to syncing while running.
@ashishb
Copy link
Contributor Author

ashishb commented Jul 19, 2019

  1. Add measurements to figure out network usage - "background/foreground", "network type (cellular/wifi)". Most network usage, as of now, is due to Geth.
  2. Add ability to turn sync on/off. I tried this 6 months back, saw crashes, and never got a chance to revisit this.
  3. Add rules to turn sync on/off. Eg. battery below 20%, turn sync off. The User is on cellular, turn sync off. App backgrounded, turn sync off. User in data saver mode, turn sync off. This layer is decoupled and configurable from the previous layer allowing us to change these decisions over time.

@trianglesphere trianglesphere self-assigned this Jul 19, 2019
@cmcewen cmcewen added the wallet label Sep 4, 2019
@nityas
Copy link
Contributor

nityas commented Oct 14, 2019

@annakaz will this capability be taken care of as part of #1171 ?

@nityas nityas added enhancement an improvement to an existing feature Priority: P2 Major triaged label for issues that have been assigned a priority labels Oct 14, 2019
@annakaz annakaz mentioned this issue Dec 6, 2019
Closed
@jeanregisser
Copy link
Contributor

Data Saver mode takes care of this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement an improvement to an existing feature investigate Priority: P2 Major triaged label for issues that have been assigned a priority wallet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@jeanregisser @ashishb @cmcewen @nityas @trianglesphere