Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[N03] Not using SafeMath #9005

Closed
cylon56 opened this issue Nov 20, 2021 · 1 comment · Fixed by #9026
Closed

[N03] Not using SafeMath #9005

cylon56 opened this issue Nov 20, 2021 · 1 comment · Fixed by #9026
Labels
stale

Comments

@cylon56
Copy link

cylon56 commented Nov 20, 2021

Not using SafeMath

PR #8360 contains a getOffchainStorageRoots function which concatenates the url bytes of an account using the help of a local totalLength variable. The totalLength is the aggregated length of all the offchainStorageRoots elements for a specified account.

Consider using OpenZeppelin's SafeMath to perform the addition to totalLength to prevent overflow and maintain consistency with the method in batchGetMetadataURL.

Part of the OpenZeppelin Release 6 Audit: @georgercarder @clarkhenry
@yorhodes yorhodes mentioned this issue Nov 30, 2021
Merged
@github-actions
Copy link
Contributor

github-actions bot commented Feb 5, 2023

This issue is stale and will be closed in 30 days without activity

@github-actions github-actions bot added the stale label Feb 5, 2023
@github-actions github-actions bot closed this as completed Mar 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use SafeMath in getOffchainStorageRoots celo-org/celo-monorepo
1 participant
@cylon56