-
Notifications
You must be signed in to change notification settings - Fork 11
[grpc] java-client -> go-server interop test fail #18
Comments
FYI the |
IIUC C++ also propagates |
I think gRPC should record stats with the |
We deliberately stopped propagating it because it doesn't really make sense outside the scope of the original request. |
Make sense. I think we need to specify this in gRPC propagation spec (census-instrumentation/opencensus-specs#66) if not propagating |
The grpc client doesn't need to propagate the method tag but the grpc server does need to add it to the context where the rpc is being processed so there should be a method tag in scope on the server side. Also, if the grpc server subsequently makes a call as a grpc client, then the method tag will be propagated since it is in scope (I don't believe gRPC has any logic for explicitly removing the method tag). |
The response by go-server does not contain tag "method".
With @songy23 's help, I found the behavior change is due to census-instrumentation/opencensus-go#566. Which behavior is correct? Should the "method" be propagated or not? If not, we should probably change the java code.
The text was updated successfully, but these errors were encountered: