Skip to content
This repository has been archived by the owner on Jul 31, 2023. It is now read-only.

Set up Github Actions for pull request validation #1237

Merged
merged 2 commits into from
Dec 8, 2020

Conversation

jsuereth
Copy link
Collaborator

  • Set up a github actions PR validation workflow.
  • Does not remove Travis CI (yet).

Example of it working: https://github.com/jsuereth/opencensus-go/pull/1/checks

@jsuereth jsuereth requested review from rghetia and a team as code owners October 23, 2020 18:38
@google-cla google-cla bot added the cla: yes label Oct 23, 2020
@nilebox
Copy link

nilebox commented Oct 25, 2020

What is the ultimate plan here? Migrate all projects from Travis to GitHub Actions?
FWIW we use CircleCI in opentelemetry-operations-go and other OpenTelemetry / Google Cloud repos, so it would be useful to have a unified CI approach across all OpenCensus / OpenTelemetry projects.

@jsuereth
Copy link
Collaborator Author

What is the ultimate plan here? Migrate all projects from Travis to GitHub Actions?
FWIW we use CircleCI in opentelemetry-operations-go and other OpenTelemetry / Google Cloud repos, so it would be useful to have a unified CI approach across all OpenCensus / OpenTelemetry projects.

Interesting. I choose GHA because (most of) OpenTelemetry is using it and because I agree we should have a unified approach. Primary goal of this CL was to figure out how expensive it would be to migrate (not very), secondary goal was to unify the projects in terms of technology if we're going to maintain both for while. Given that OC is directly moving to OT, I thought unifying with OSS OT community would be better. It appears that within OT, (JS/Go APIs, Collector + Specification) use CircleCI and the spot check I did (swift, c++, java, .NET, erlang, Python, JavaScript) use GHA. I'm curious why there's such divergence between the repositories, do you know why to choose CircleCI over GHA?

.github/workflows/build.yml Outdated Show resolved Hide resolved
force a specific version of ubuntu

Co-authored-by: Aaron Abbott <aaronabbott@google.com>
lfs: true
- uses: actions/setup-go@v2
with:
go-version: '^1.11.0'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets use something more recent. Maybe 1.14 or 1.15. I think GO11MODULE isn't needed after that.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is matching what we had in Travis-CI. I'm not going to bump to 1.14/1.15 unless we're officially dropping support for older Go version here, which we're not. This is just a migration.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants