Skip to content
This repository has been archived by the owner on Jul 31, 2023. It is now read-only.

Adds an exported function to flush interval reader #1248

Conversation

quentin-cha
Copy link
Contributor

This is a quick fix (bit hacky) to get me closer to fixing census-ecosystem/opencensus-go-exporter-stackdriver#43,
by providing an exported function on IntervalReader to flush its content.

It doesn't change any existing behavior of IntervalReader, it only adds a way for the owner of IntervalReader to flush its content when needed.

@quentin-cha quentin-cha requested review from rghetia and a team as code owners December 28, 2020 16:14
@google-cla google-cla bot added the cla: yes label Dec 28, 2020
@quentin-cha quentin-cha changed the title Adds an exported function to flush internal reader Adds an exported function to flush interval reader Jan 20, 2021
@quentin-cha quentin-cha requested review from dashpole and removed request for a team January 21, 2021 17:03
@dashpole
Copy link
Collaborator

whoops. one more comment, then i'll merge

@dashpole dashpole merged commit 13369a4 into census-instrumentation:master Jan 22, 2021
@quentin-cha
Copy link
Contributor Author

Thank you so much your help!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants