Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker compose workflow doesn't work as expected #118

Closed
mehaase opened this issue Nov 20, 2023 · 1 comment
Closed

Docker compose workflow doesn't work as expected #118

mehaase opened this issue Nov 20, 2023 · 1 comment

Comments

@mehaase
Copy link
Contributor

mehaase commented Nov 20, 2023

The docker-compose.yml workflow runs against the :latest tag for the docker image, and the workflow does not depend on the execution of the docker.yml workflow. So it's really testing some previous version of the docker image, not the one associated with the current PR/commit.

We probably need to merge the docker-compose test into the docker workflow in such a way that it runs after the image is successfully built. (And be sure to use the correct tag -- I'm not sure if our docker build updates the :latest tag or not.)

@mehaase mehaase closed this as completed in f7bfc63 Jan 8, 2025
@mehaase
Copy link
Contributor Author

mehaase commented Jan 8, 2025

I removed this file for now since it's not doing anything.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant