Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Component content from JSDocs #246

Closed
8 of 9 tasks
Tracked by #243
PtitBen opened this issue Nov 6, 2023 · 8 comments
Closed
8 of 9 tasks
Tracked by #243

Component content from JSDocs #246

PtitBen opened this issue Nov 6, 2023 · 8 comments
Assignees
Labels
Status: On Hold Awaiting for clarification or another issue to be resolved Type: Documentation Improvements or additions to documentation

Comments

@PtitBen
Copy link
Contributor

PtitBen commented Nov 6, 2023

Outcome

We pull content automatically from the components' codebase into the documentation.

Scope

The following content blocks:

  • Name
  • Main purpose
  • Specifications
  • Events
  • Permitted tags for slot
  • Component placement - list of components
  • Component display name
  • Component categories [Form, Experience]
  • Component flags [internal, deprecated]
@PtitBen PtitBen mentioned this issue Nov 6, 2023
26 tasks
@PtitBen PtitBen added the Type: Documentation Improvements or additions to documentation label Nov 6, 2023
@PtitBen PtitBen added this to the Internal tools milestone Nov 6, 2023
@MekalaNagarajan-Centrica
Copy link
Contributor

Permitted Tags

Jsdoc and web component analyzer support permitted tags for a slot as shown below.

Image

When the custom elements are analysed and transformed into JSON format, the permitted tags are not included.

  "slots": [
    {
      "name": "heading",
      "description": "The heading of the accordion."
    },
    {
      "description": "Anonymous slot for expanders."
    }
  ]

@MekalaNagarajan-Centrica
Copy link
Contributor

PR to pull permitted tag names and component placements centrica-engineering/muon#571

"slots": [
  {
    "name": "label",
    "description": "The label for the input.",
    "permittedTagNames": [
      "label"
    ]
  },
  {
    "description": "The form element passed in such as input, select, textarea.",
    "permittedTagNames": [
      "input",
      "select"
    ]
  },
  {
    "name": "tip-details",
    "description": "The tip details related to the helper.",
    "permittedTagNames": [
      "div"
    ]
  }
],
"placements": [
  "muon-form"
 ]

@MekalaNagarajan-Centrica
Copy link
Contributor

Muon PR to split analyzer and json transformation centrica-engineering/muon#572

@MekalaNagarajan-Centrica
Copy link
Contributor

MekalaNagarajan-Centrica commented Dec 4, 2023

Nucleus changes

@MekalaNagarajan-Centrica
Copy link
Contributor

jsdoc slots in nucleus docs #269

@andij andij changed the title Automate pull for some of the content Component content from JSDocs Jan 4, 2024
@MekalaNagarajan-Centrica
Copy link
Contributor

PR to update jsdoc https://github.com/ConnectedHomes/nucleus/pull/3333. This includes

  • Component display name
  • Component category
  • Component internal flag

@MekalaNagarajan-Centrica
Copy link
Contributor

Update sidebar using jsdoc #292

@RobTobias123 RobTobias123 added the Status: On Hold Awaiting for clarification or another issue to be resolved label Jan 24, 2024
@MekalaNagarajan-Centrica
Copy link
Contributor

This ticket can be closed as the below work are moved to individual tickets.
@placement updation is moved to #364
description updation is moved to #363

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: On Hold Awaiting for clarification or another issue to be resolved Type: Documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

3 participants