Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

health probe #252

Closed
cpanato opened this issue Dec 14, 2018 · 8 comments
Closed

health probe #252

cpanato opened this issue Dec 14, 2018 · 8 comments

Comments

@cpanato
Copy link

cpanato commented Dec 14, 2018

Hello
this is a nice product, i like it thanks for that

One question does the api have any health endpoint to check? I would like to setup k8s Liveness and Readiness Probes but did not found in the documentation

thanks!

@FZambia
Copy link
Member

FZambia commented Dec 14, 2018

Hello, thanks.

At moment Centrifugo has no health probe endpoint, there is also similar request in Centrifuge library which is the core of Centrifugo - centrifugal/centrifuge#27 - with a bit more details.

Could you tell me which things you expect to be checked when calling this endpoint?

@sj26
Copy link

sj26 commented Dec 19, 2018

Imho, a fixed "200 OK" response would be sufficient. It should exercise that the application is available to service requests. Generally health checks should not check upstream services (i.e. redis).

@FZambia
Copy link
Member

FZambia commented Dec 19, 2018

ok, will include health endpoint into next release then if it already has benefits in this state. At work we have services that check external storages in liveness probe. I suppose checking external services has some reasoning in certain scenarios - broken reconnect, possible deadlock in drivers, connectivity lost forever for the whole underlying machine. But this can be an extra functionality added later.

@cpanato
Copy link
Author

cpanato commented Dec 19, 2018

thanks, sounds great. please let me know if need help or where can i help :)

@sj26
Copy link

sj26 commented Dec 20, 2018

That's true, Kubernetes has two different probes which differentiate "this service is alive" versus "this service is healthy and all upstreams are okay"

https://kubernetes.io/docs/tasks/configure-pod-container/configure-liveness-readiness-probes/

@FZambia
Copy link
Member

FZambia commented Dec 30, 2018

Released with v2.1.0, docs here

@FZambia FZambia closed this as completed Dec 30, 2018
@sj26
Copy link

sj26 commented Dec 31, 2018

Thanks!

@cpanato
Copy link
Author

cpanato commented Jan 3, 2019

thanks, I've updated the helm charts to use that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants